Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel/submit routes for group/role management #1448

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

fhlavac
Copy link
Contributor

@fhlavac fhlavac commented Jun 8, 2023

This should fix RHCLOUD-26267
[RBAC] Router issues

Fixed broken routing for submit/cancel remove/edit group/role.

@fhlavac fhlavac requested a review from a team June 8, 2023 21:30
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (6bf069b) 55.83% compared to head (fe3c1a5) 55.83%.

❗ Current head fe3c1a5 differs from pull request most recent head 1b1ddb4. Consider uploading reports for the commit 1b1ddb4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1448   +/-   ##
=======================================
  Coverage   55.83%   55.83%           
=======================================
  Files         149      149           
  Lines        3256     3256           
  Branches      928      928           
=======================================
  Hits         1818     1818           
  Misses       1301     1301           
  Partials      137      137           
Impacted Files Coverage Δ
src/smart-components/group/group.js 2.66% <ø> (ø)
src/smart-components/group/groups.js 65.21% <0.00%> (ø)
src/smart-components/role/role.js 76.25% <ø> (ø)
src/smart-components/group/edit-group-modal.js 75.00% <100.00%> (ø)
src/smart-components/group/remove-group-modal.js 85.71% <100.00%> (ø)
src/smart-components/role/edit-role-modal.js 92.68% <100.00%> (ø)
src/smart-components/role/remove-role-modal.js 89.65% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Hyperkid123 Hyperkid123 merged commit e6af043 into RedHatInsights:master Jun 9, 2023
@Hyperkid123 Hyperkid123 deleted the fix-role branch June 9, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants