Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build release 3.0.4 #84

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

teleyinex
Copy link
Contributor

All the work has been done by @kosmosjamaa. This just uses the fonts built and uploaded by kosmosjamaa to Mediafire as a PR for easily fixing it upstream.

All the work has been done by @kosmosjamaa. This just uses the fonts
built by kosmosjamaa to Mediafire as PR for easily fixing it upstream.
Copy link
Contributor

@andyfitzsuse andyfitzsuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is embarrassingly late,

Thank you for the updated build, it works for me.

@andyfitzsuse
Copy link
Contributor

@castastrophe anyone back at Red Hat able to merge this ?

When I moved this repo over and left Red Hat I lost access to it.

@bproffitt
Copy link
Member

@Andyfitz I'll merge it. Want me to add you back in here?

@michaelfaith
Copy link

michaelfaith commented Jul 1, 2021

@bproffitt @Andyfitz does there need to be a new tag for this update? The zip attached to 3.0.4 has the old webfont files. That's likely going to throw off downstream consumers RE: #75

@andyfitzsuse
Copy link
Contributor

@bproffitt @castastrophe I no longer have access to remediate the release issue.
Are you able to take @michaelfaith 's advice to amend the latest release with the updates?

@michaelfaith
Copy link

michaelfaith commented Jul 12, 2021

@bproffitt @castastrophe any chance of getting this resolved soon? There's a pending issue in Google Fonts github, to update their copies of the font, which they've queued up to work on, but I'm afraid if they grab the last release, it won't include this bug fix, which we've been waiting for for a long time. The 3.0.4 tag doesn't include the updated webfont files. If they take that package we'll still be at square one with this.

@bproffitt
Copy link
Member

I am not a maintainer on this repo, just the organization. Can you check with @jimmac ?

@michaelfaith
Copy link

@bproffitt thanks getting back. I just sent him an email to see if he can help with it.

@jimmac
Copy link
Contributor

jimmac commented Jul 13, 2021

I'm afraid I'm not the savior you're looking for. No admin rights here either.

@michaelfaith
Copy link

@bproffitt is there someone else that would able to help?

@DelveFonts
Copy link
Collaborator

Hi Everyone, I'm Delve Withrington. I think I may be able to help but github is not my forté so I need some direction on how to do what is needed for this.

@michaelfaith
Copy link

michaelfaith commented Jul 13, 2021

@DelveFonts thanks for jumping in. @Andyfitz mentioned possibly amending the existing 3.0.4 release, and he may be able to share what he meant there. The easiest thing, though, might just be to create a new 3.0.5 release, and closing out this issue: #75

@michaelfaith
Copy link

@DelveFonts
Copy link
Collaborator

@michaelfaith Thank you for the insight and the links concerning managing releases. I'm reviewing all of this now to get a handle on it before I make any changes. I don't want to break anything. 😱

@michaelfaith
Copy link

It looks like Google's starting to move on their side. It got assigned to someone earlier today.
image

@DelveFonts let me know if you need any more help with this.

@DelveFonts
Copy link
Collaborator

@michaelfaith Sorry for the delay. Thanks for pointing out the new activity over on GF. A question came up that I need clarification on: Did someone already export the webfonts after v3.0.4 with the line-height issue corrected? If so, where are those? Otherwise, I'll do that for a v3.0.5 release.

@michaelfaith
Copy link

@DelveFonts this PR merged in the post-3.0.4 webfonts (https://github.com/RedHatOfficial/Overpass/pull/84/files) So, I think it should be good since the PR merged. But it was merged after the release was made, so the new release should effectively be 3.0.4 + this PR.

@michaelfaith
Copy link

@DelveFonts any luck with this?

@michaelfaith
Copy link

@bproffitt @castastrophe can someone please do this release? Has this repo become abandoned?

@DelveFonts
Copy link
Collaborator

@michaelfaith I've published the v3.0.5 release: https://github.com/RedHatOfficial/Overpass/releases/tag/v3.0.5 is anything missing or incorrect?

@michaelfaith
Copy link

@DelveFonts thanks for closing the loop on this. Really appreciate it. The release looks good. You should also be able to close this issue out now: #75

@DelveFonts
Copy link
Collaborator

😅 Yay! Thanks for confirming @michaelfaith. #75 is now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants