Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #725: straight the error messages #813

Merged
merged 4 commits into from
Dec 30, 2022
Merged

Fix #725: straight the error messages #813

merged 4 commits into from
Dec 30, 2022

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented Aug 30, 2022 •
edited
Loading

Fix #725

@gkorland gkorland changed the title Fix #725: straight the error message Fix #725: straight the error messages Aug 30, 2022
@gkorland gkorland linked an issue Aug 30, 2022 that may be closed by this pull request
'ERR' prefix not exist in 'Existing key has wrong Redis type' error #725
Closed
@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited
Loading

Codecov Report

Base: 81.36% // Head: 81.36% // No change to project coverage 👍

Coverage data is based on head (302474f) compared to base (1b381b7).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files          14       14           
  Lines        3896     3896           
=======================================
  Hits         3170     3170           
  Misses        726      726
Impacted Files Coverage Δ
src/commands.rs 95.67% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gkorland gkorland merged commit b3ea215 into master Dec 30, 2022
@gkorland gkorland deleted the gkorland-err-standard branch December 30, 2022 21:18
rafie pushed a commit that referenced this pull request Jan 31, 2023
@gkorland @rafie
Fix #725: straight the error messages (#813)
85afb14 
* straight the error message

* fix build

* format code

(cherry picked from commit b3ea215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadmi oshadmi oshadmi approved these changes

@MeirShpilraien MeirShpilraien Awaiting requested review from MeirShpilraien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'ERR' prefix not exist in 'Existing key has wrong Redis type' error
3 participants
@gkorland @CLAassistant @oshadmi