Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements and fixes for release workflow #205

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

GuyAv46
Copy link
Contributor

@GuyAv46 GuyAv46 commented Nov 16, 2023

  1. ::set-output is deprecated. Changing to the new syntax.
  2. simplified step
  3. addressing github.ref is empty for workflows triggered by release actions/runner#2788
  4. typo fix on input for snok/install-poetry

@GuyAv46 GuyAv46 requested a review from chayim November 16, 2023 08:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3671409) 34.05% compared to head (69e7ab4) 34.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   34.05%   34.05%           
=======================================
  Files          17       17           
  Lines        2393     2393           
=======================================
  Hits          815      815           
  Misses       1578     1578           
Flag Coverage Δ
unittests 34.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 merged commit 885ff1f into master Nov 16, 2023
23 checks passed
@GuyAv46 GuyAv46 deleted the guyav-CI_improvement branch November 16, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants