Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password as a parameter for Env - [MOD-6117] #208

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

GuyAv46
Copy link
Contributor

@GuyAv46 GuyAv46 commented Nov 30, 2023

Enable specifying a password when creating a new Env

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26528b8) 34.08% compared to head (9d81bfd) 34.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   34.08%   34.10%   +0.02%     
==========================================
  Files          17       17              
  Lines        2406     2407       +1     
==========================================
+ Hits          820      821       +1     
  Misses       1586     1586              
Flag Coverage Δ
unittests 34.10% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 changed the title Add password as a parameter for Env Add password as a parameter for Env - [MOD-6117] Nov 30, 2023
Copy link
Collaborator

@alonre24 alonre24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuyAv46 GuyAv46 merged commit 05ab1d2 into master Dec 3, 2023
23 checks passed
@GuyAv46 GuyAv46 deleted the guyav-password_env_parameter branch December 3, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants