Disallow combining parallel execution with --no-output-catch #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshadmi
reviewed
Dec 18, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 32.31% 32.28% -0.04%
==========================================
Files 17 17
Lines 2562 2565 +3
==========================================
Hits 828 828
- Misses 1734 1737 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
oshadmi
approved these changes
Dec 18, 2023
GuyAv46
approved these changes
Dec 18, 2023
iddm
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes that were made on this PR: #211, changed the way tests results are send to the main processes when parallelism it used. Instead of each processes prints its own output, each processes sends its stdout to the main processes and the main processes prints it. This prevent us from been able to redirect the subprocesses stdout to Redis when using parallelism. Notice that this limitation is not applies when used without parallelism.