Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fork as the starting method of a sub-process #215

Merged
merged 12 commits into from
Jan 7, 2024

Conversation

GuyAv46
Copy link
Contributor

@GuyAv46 GuyAv46 commented Jan 4, 2024

  • Explicitly set the sub-process start method to 'fork', as the default method is different among different OSs, and we rely on forking the memory (local functions, global Defaults struct, and more)
  • Setting some default values in _runTest to be no-op callable so we can always call them (and not have to check if they're None)

To properly run with parallelism on macOS, you'll have to call RLTest with OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES

MeirShpilraien
MeirShpilraien previously approved these changes Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (d291d4c) 32.50% compared to head (bad25f6) 32.52%.

Files Patch % Lines
RLTest/__main__.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   32.50%   32.52%   +0.01%     
==========================================
  Files          17       17              
  Lines        2587     2586       -1     
==========================================
  Hits          841      841              
+ Misses       1746     1745       -1     
Flag Coverage Δ
unittests 32.52% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 merged commit 553f633 into master Jan 7, 2024
23 checks passed
@GuyAv46 GuyAv46 deleted the guyav-fork_as_process_method branch January 7, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants