Set timeout of a wider range of the test [MOD-6441] #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeirShpilraien
force-pushed
the
apply_wider_timeout
branch
from
63e3437
to
2a201e2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 32.52% 32.45% -0.07%
==========================================
Files 17 17
Lines 2586 2591 +5
==========================================
Hits 841 841
- Misses 1745 1750 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GuyAv46
reviewed
Jan 11, 2024
| @@ -385,12 +387,16 @@ def watcher_thread(self): | |||
| print(Colors.Bred("Failed on timeout function, %s" % str(e))) | |||
| os._exit(1) | |||
|
|
|||
| def reset(self): | |||
| self.timeout_time = time.time() + self.timeout | |||
There was a problem hiding this comment.
shouldn't it acquire the condition while making this change?
There was a problem hiding this comment.
Python has a GIL anyway so it will not cause the other thread not to see the update. The worst that can happened is that there will be a context switch before the timeout_time was set, in this case we can consider it as not been set yet.
GuyAv46
approved these changes
Jan 11, 2024
alonre24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR changed the test timeout feature to be applied on a wider range of the test lifetime, including initialization and shutdown.
In order to achieve this, the PR changes the way the timeout works. instead of sleeping for the given amount of timeout, the timeout mechanism now calculate the time on which the timeout will reach and periodically check for the timeout. This allows the test to reset the timeout if needed (for example when running on a class of tests and not on a single function) while the timeout still apply on the entire test lifetime from start to end.