Publicizing RedisKey member #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r a module that wants to call C fns given Rust structs
iddm
reviewed
May 2, 2023
| @@ -33,7 +33,7 @@ pub enum KeyMode { | |||
| #[derive(Debug)] | |||
| pub struct RedisKey { | |||
| ctx: *mut raw::RedisModuleCtx, | |||
| key_inner: *mut raw::RedisModuleKey, | |||
| pub key_inner: *mut raw::RedisModuleKey, | |||
There was a problem hiding this comment.
I suggest we instead have a method to return it, rather than having it visible to everyone. Usually, such methods are called as_ptr and as_mut_ptr. I suggest we follow the conventional naming and leave this struct member private in favour of having a method.
I also didn't see where it was needed exactly and in what way. Perhaps, if there are examples of where it is needed, we could make it accessible in a more optimal way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe
RedisKey::key_innershouldn't be public in the general case, but it is required for a module that wants to call C fns expecting*RedisModuleKeygiven Rust structs.