Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add firstTimestamp field to the keyInfo struct. #160

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

temphiza
Copy link

Proposed change:

This change adds the field firstTimestamp to the KeyInfo struct, which should be in line with the TS.INFO response of the latest version of the redis-timeseries module.

Testing:

  • Tests updated: TestClientInfo, TestAdd, TestAddWithRetention
  • Test added: TestClientInfoRange

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 14, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (e83b198) 82.74% compared to head (8a77ec6) 82.79%.

❗ Current head 8a77ec6 differs from pull request most recent head 55c21ef. Consider uploading reports for the commit 55c21ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   82.74%   82.79%   +0.05%     
==========================================
  Files           7        7              
  Lines         591      593       +2     
==========================================
+ Hits          489      491       +2     
  Misses         59       59              
  Partials       43       43              
Impacted Files Coverage Δ
common.go 89.74% <ø> (ø)
reply_parser.go 67.23% <100.00%> (+0.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant