Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TS.QUERYINDEX TS.ALTER TS.INCRBY/TS.DECRBY TS.MADD #60

Merged
merged 3 commits into from
May 8, 2020

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented May 6, 2020

for #53#57#56#55#54

@filipecosta90 filipecosta90 self-requested a review May 6, 2020 21:08
filipecosta90
filipecosta90 previously approved these changes May 6, 2020
@dengliming dengliming changed the title Add support for TS.QUERYINDEX TS.ALTER Add support for TS.QUERYINDEX TS.ALTER TS.INCRBY/TS.DECRBY TS.MADD May 7, 2020
client.go Outdated Show resolved Hide resolved
filipecosta90
filipecosta90 previously approved these changes May 8, 2020
@dengliming
Copy link
Contributor Author

It seems that CI/TEST has been taking a long time.

@filipecosta90
Copy link
Collaborator

It seems that CI/TEST has been taking a long time.

for some reason the circle build on PRs was disabled. I believe the fastest way to trigger it properly is to add another test to force a code change. I don't see a way on circle to trigger the build myself. Can we add one more test ( for example on Madd with multiple series )? That should do it =)

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #60 into master will increase coverage by 0.01%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   82.44%   82.46%   +0.01%     
==========================================
  Files           6        6              
  Lines         393      439      +46     
==========================================
+ Hits          324      362      +38     
- Misses         35       39       +4     
- Partials       34       38       +4     
Impacted Files Coverage Δ
common.go 93.10% <ø> (ø)
client.go 86.98% <82.60%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a81d2...b26de7f. Read the comment docs.

@filipecosta90 filipecosta90 self-requested a review May 8, 2020 13:47
@filipecosta90 filipecosta90 merged commit 0968184 into RedisTimeSeries:master May 8, 2020
@filipecosta90
Copy link
Collaborator

thank you for contribution @dengliming =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants