Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds NewClientFromPool and Close methods. includes example #62

Merged
merged 5 commits into from
May 11, 2020

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented May 7, 2020

fixes #61 and #10

@filipecosta90 filipecosta90 added the enhancement New feature or request label May 7, 2020
@filipecosta90 filipecosta90 linked an issue May 7, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #62 into master will decrease coverage by 1.36%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   82.46%   81.09%   -1.37%     
==========================================
  Files           6        6              
  Lines         439      455      +16     
==========================================
+ Hits          362      369       +7     
- Misses         39       46       +7     
- Partials       38       40       +2     
Impacted Files Coverage Δ
pool.go 80.43% <54.54%> (-13.86%) ⬇️
client.go 87.35% <100.00%> (+0.37%) ⬆️
common.go 86.20% <0.00%> (-6.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0968184...a4ed4da. Read the comment docs.

@gkorland gkorland requested a review from danni-m May 11, 2020 09:27
@filipecosta90 filipecosta90 merged commit 2169513 into master May 11, 2020
@filipecosta90 filipecosta90 deleted the pool.improve branch August 7, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants