Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from gopkg to go.mod #74

Merged
merged 3 commits into from
Aug 3, 2020
Merged

Switched from gopkg to go.mod #74

merged 3 commits into from
Aug 3, 2020

Conversation

filipecosta90
Copy link
Collaborator

fixes #73
This PR enable Go Modules and it's backwards compatible with old go versions.

@filipecosta90 filipecosta90 added the enhancement New feature or request label Aug 2, 2020
@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files           7        7           
  Lines         477      477           
=======================================
  Hits          391      391           
  Misses         46       46           
  Partials       40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c528b...b362f95. Read the comment docs.

go.mod Show resolved Hide resolved
danni-m
danni-m previously approved these changes Aug 2, 2020
Copy link

@danni-m danni-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipecosta90 LGTM, we should check whats the proper version for redigo

@filipecosta90
Copy link
Collaborator Author

@filipecosta90 LGTM, we should check whats the proper version for redigo

@danni-m IMO we should keep the versions at the minimum compatible version as possible.

@filipecosta90 filipecosta90 merged commit 3a9e06b into master Aug 3, 2020
@filipecosta90 filipecosta90 deleted the go.mod branch August 3, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rely on Go Modules to ensure package dependencies and replicable builds
2 participants