Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuBuilder: Add support for sortOperationsAlphabetically and sortTagsAlphabetically #1843

Merged
merged 3 commits into from
Dec 30, 2021

Conversation

flouthoc
Copy link
Contributor

@flouthoc flouthoc commented Dec 27, 2021

Already documented but is currently NO-OP and not implemented
sortOperationsAlphabetically and sortTagsAlphabetically .

Allows sorting operations in sidebar menu according to their name
configured which is by default summary from Swaggerspec

TLDR:
Following commit adds support for sortOperationsAlphabetically and sortTagsAlphabetically already
documented but not implemented here: https://redoc.ly/docs/api-reference-docs/guides/migration-guide-2-0/#automated-sorting

@flouthoc
Copy link
Contributor Author

@RomanHotsiy PTAL

Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment.

src/services/MenuBuilder.ts Outdated Show resolved Hide resolved
Already documented but is currently `NO-OP` and not implemented
`sortOperationsAlphabetically`.

Allows sorting operations in sidebar menu according to their `name`
configured which is by default `summary` from Swaggerspec

TLDR:
Following commit adds support for `sortOperationsAlphabetically` already
documented but not implemented here: https://redoc.ly/docs/api-reference-docs/guides/migration-guide-2-0/#automated-sorting

Signed-off-by: flouthoc <[email protected]>
@flouthoc
Copy link
Contributor Author

@RomanHotsiy Thanks fixed :)

@flouthoc
Copy link
Contributor Author

@RomanHotsiy Let me know if anything else needs to be done. :)

@Oprysk Oprysk changed the title MenuBuilder: Add support for sortOperationsAlphabetically MenuBuilder: Add support for sortOperationsAlphabetically and sortTagsAlphabetically Dec 29, 2021
@rhatdan
Copy link

rhatdan commented Dec 29, 2021

Can this be merged now?

@Oprysk Oprysk merged commit 831b207 into Redocly:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants