-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MenuBuilder: Add support for sortOperationsAlphabetically
and sortTagsAlphabetically
#1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2021
@RomanHotsiy PTAL |
RomanHotsiy
requested changes
Dec 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment.
Already documented but is currently `NO-OP` and not implemented `sortOperationsAlphabetically`. Allows sorting operations in sidebar menu according to their `name` configured which is by default `summary` from Swaggerspec TLDR: Following commit adds support for `sortOperationsAlphabetically` already documented but not implemented here: https://redoc.ly/docs/api-reference-docs/guides/migration-guide-2-0/#automated-sorting Signed-off-by: flouthoc <[email protected]>
flouthoc
force-pushed
the
sort-operations
branch
from
December 27, 2021 11:06
7e406b5
to
a7b75f3
Compare
@RomanHotsiy Thanks fixed :) |
@RomanHotsiy Let me know if anything else needs to be done. :) |
Oprysk
approved these changes
Dec 29, 2021
Oprysk
changed the title
MenuBuilder: Add support for
MenuBuilder: Add support for Dec 29, 2021
sortOperationsAlphabetically
sortOperationsAlphabetically
and sortTagsAlphabetically
RomanHotsiy
approved these changes
Dec 29, 2021
Can this be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already documented but is currently
NO-OP
and not implementedsortOperationsAlphabetically
andsortTagsAlphabetically
.Allows sorting operations in sidebar menu according to their
name
configured which is by default
summary
from SwaggerspecTLDR:
Following commit adds support for
sortOperationsAlphabetically
andsortTagsAlphabetically
alreadydocumented but not implemented here: https://redoc.ly/docs/api-reference-docs/guides/migration-guide-2-0/#automated-sorting