Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up the discriminator mapping in the remove-x-internal decorator #1694

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Aug 29, 2024

What/Why/How?

Fixed the remove-x-internal decorator, which was not removing the reference in the corresponding discriminator mapping while removing the original $ref.

Reference

Fixes #1649

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr self-assigned this Aug 29, 2024
@tatomyr tatomyr requested review from a team as code owners August 29, 2024 08:02
Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: b7b20da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 968.6 ± 20.0 949.7 1010.1 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 975.5 ± 25.5 940.6 1033.0 1.01 ± 0.03

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.77% 4972/6312
🟡 Branches
67.55% (+1.2% 🔼)
2059/3048
🟡 Functions 73.13% 822/1124
🟡 Lines 79.08% 4691/5932

Test suite run success

803 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from b7b20da

@tatomyr tatomyr changed the title fix: remove the discriminator mapping in the remove-x-internal decorator fix: clean up the discriminator mapping in the remove-x-internal decorator Aug 29, 2024
@tatomyr tatomyr force-pushed the fix/remove-x-internal-discriminator-mapping branch from 9afd155 to 20f7448 Compare August 29, 2024 12:44
@tatomyr tatomyr force-pushed the fix/remove-x-internal-discriminator-mapping branch from d9c04a6 to b7b20da Compare September 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all usages of component marked x-internal
1 participant