Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AGX and AGX Punchy tonemapper options to Environment #5

Closed
wants to merge 2 commits into from
Closed

Add AGX and AGX Punchy tonemapper options to Environment #5

wants to merge 2 commits into from

Conversation

Norrox
Copy link
Contributor

@Norrox Norrox commented Sep 30, 2024

@filipworksdev
Copy link

This is pretty interesting. Is there a reason why you removed tonemap_reinhard?

@Norrox
Copy link
Contributor Author

Norrox commented Oct 3, 2024

This is pretty interesting. Is there a reason why you removed tonemap_reinhard?

It's not my PR, i just moved it from upstream to Redot.
But it looks like it's still there? :D
image

@yarbelk
Copy link

yarbelk commented Oct 5, 2024

Man, I like these tonemaps.

Bioblaze added a commit that referenced this pull request Oct 5, 2024
@Bioblaze
Rebranding Image Test #5
f48bb50
@Redot-Engine Redot-Engine deleted a comment Oct 6, 2024
JohnnyThunder2
JohnnyThunder2 approved these changes Oct 9, 2024
View reviewed changes
Copy link

@JohnnyThunder2 JohnnyThunder2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been looking this code over for awhile now... I believe I'm at the point I understand it enough to approve it.

@Norrox Norrox closed this by deleting the head repository Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyThunder2 JohnnyThunder2 JohnnyThunder2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Norrox @filipworksdev @yarbelk @JohnnyThunder2 @Calinou