Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera resources relese #148

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

janmarektelc
Copy link

Camera resources are released, NFC reader is available after barcode reader usage.

#118

@juezen
Copy link

juezen commented Nov 14, 2023

I had an issue where this plugin didn't release "camera2" for Android properly. This PR solved my problem! It Needs to be merged!

@joaquincubero22
Copy link

Hello, we need this merge for an Implementation that is failing without this PR, when opening a session of the ZXing and then close it and open the camera2 it fails with this fix it works.

@Yurinabaia
Copy link

Could you analyze this PR to include in the library

@EGoverde
Copy link

This PR fixed an issue for me when I try to use the camera preview from another package it won't work if the barcode view was shown earlier. This properly cleans the resources up so it can be used again elsewhere. Would like it to be merged as well!

@MartyIX
Copy link

MartyIX commented Jan 30, 2024

Friendly ping @Redth

@Silverdark
Copy link

This PR solves the issue for me as well.
@Redth please check if you could merge it, I would appreciate it.

@aluna-magaya
Copy link

This PR fixes an issue I'm facing. I would appreciate if it gets merged. @Redth

@Silverdark
Copy link

Hi @Redth, I would be grateful if you could check this PR 🙂

@figuerres
Copy link

is there a way to get a version with this fix to test with ? i am not a wizzard at how all this github pull stuff...... but i need a working version to not make users have to re-start an app for each barcode they read.

@EGoverde
Copy link

is there a way to get a version with this fix to test with ? i am not a wizzard at how all this github pull stuff...... but i need a working version to not make users have to re-start an app for each barcode they read.

Until merged the fix is only available in the repository by @janmarektelc . If you want to use it until it is finally merged and the NuGet is updated, you can include the source in your own project. In that case head to the below URL and download the source either as a ZIP file or by cloning it.

https://github.com/janmarektelc/ZXing.Net.Maui/tree/bugfix-118-release-camera-resources

Once you have the source locally add it to your app by adding a project reference to the .csproj. Don't forget to remove the NuGet as well.

@Redth without this PR the project cannot really be used in a production environment. Please, please merge and update the package.

@Redth Redth merged commit 57eef38 into Redth:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants