Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaN check for trapezoidal routines. #738

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

ACSimon33
Copy link
Contributor

Description

Following up on #737 I've implemented a NaN check for trapezoidal matrices. I've added adirect argument to support a whole bunch of trapezoidal matrices (e.g. those which occur in xLARFB):

Diagonals 'F' (front / forward) and 'B' (back / backward):

        A = ( F       )           A = ( F     B       )
            (    F    )               (    F     B    )
            ( B     F )               (       F     B )
            (    B    )
            (       B )

      direct = 'F', uplo = 'L':

        A = ( *       )           A = ( *             )
            ( *  *    )               ( *  *          )
            ( *  *  * )               ( *  *  *       )
            ( *  *  * )
            ( *  *  * )

      direct = 'F', uplo = 'U':

        A = ( *  *  * )           A = ( *  *  *  *  * )
            (    *  * )               (    *  *  *  * )
            (       * )               (       *  *  * )
            (         )
            (         )

      direct = 'B', uplo = 'L':

        A = (         )           A = ( *  *  *       )
            (         )               ( *  *  *  *    )
            ( *       )               ( *  *  *  *  * )
            ( *  *    )
            ( *  *  * )

      direct = 'B', uplo = 'U':

        A = ( *  *  * )           A = (       *  *  * )
            ( *  *  * )               (          *  * )
            ( *  *  * )               (             * )
            (    *  * )
            (       * )

For now, I've only applied the new NaN check to LAPACKE_?lantr. But the NaN check is designed to also work for LAPACKE_?larfb and potential other routines. @langou I'll investigate those later since I want first confirm with you that the interface that I've chosen is alright.

Additionally, I fixed some missing symbols in the Makefile which I forgot to add in my last PR for #722.

Checklist

@langou
Copy link
Contributor

langou commented Oct 27, 2022

Thanks @ACSimon33. This is great. I like the pictures of the matrices occurring in LARFB, very nicely done.

@langou langou merged commit 17f99f2 into Reference-LAPACK:master Oct 27, 2022
@ACSimon33 ACSimon33 deleted the LAPACKE_norm_routines branch October 28, 2022 07:31
@julielangou julielangou added this to the LAPACK 3.11.0 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NaN check in LAPACKE_?lantr isn't correct for m != n
4 participants