Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaling in (S/D)TGSNA, fix #103, thanks to @elivanova #830

Merged
merged 1 commit into from
May 24, 2023

Conversation

weslleyspereira
Copy link
Collaborator

Closes #103.

This PR addresses an old issue using the solution presented by @elivanova in #103 (comment).

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1fafb88) 0.00% compared to head (5c841b1) 0.00%.

❗ Current head 5c841b1 differs from pull request most recent head 5db45a2. Consider uploading reports for the commit 5db45a2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #830    +/-   ##
========================================
  Coverage    0.00%    0.00%            
========================================
  Files        1908     1908            
  Lines      187072   186958   -114     
========================================
+ Misses     187072   186958   -114     
Impacted Files Coverage Δ
SRC/cgbsvx.f 0.00% <ø> (ø)
SRC/cgebal.f 0.00% <0.00%> (ø)
SRC/cgees.f 0.00% <ø> (ø)
SRC/cgeesx.f 0.00% <ø> (ø)
SRC/cgeev.f 0.00% <ø> (ø)
SRC/cgeevx.f 0.00% <ø> (ø)
SRC/cgejsv.f 0.00% <ø> (ø)
SRC/cgels.f 0.00% <ø> (ø)
SRC/cgelsd.f 0.00% <ø> (ø)
SRC/cgelss.f 0.00% <ø> (ø)
... and 242 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@martin-frbg martin-frbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, may I suggest editing the PR title to something like "Fix scaling in (S/D)TGSNA" instead of "Fix 103" ?

@langou langou changed the title Fix 103 thanks to @elivanova Fix scaling in (S/D)TGSNA, fix #103, thanks to @elivanova May 24, 2023
@langou
Copy link
Contributor

langou commented May 24, 2023

Again, may I suggest editing the PR title to something like "Fix scaling in (S/D)TGSNA" instead of "Fix 103" ?

Done. Thanks for the suggestion.

@langou langou merged commit 24c6a91 into Reference-LAPACK:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in stgsna.f / dtgsna.f, which moves to incorrect SVD calculations.
3 participants