Skip to content

Commit

Permalink
fix(select): unset cursor of header items (#571)
Browse files Browse the repository at this point in the history
* fix(select): unset cursor of header items
* fix(select) clarify comment
  • Loading branch information
wattachai-lseg authored Jan 20, 2023
1 parent d1c9bc2 commit eff8a75
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 3 deletions.
2 changes: 0 additions & 2 deletions packages/elemental-theme/src/custom-elements/ef-select.less
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
}
// #endregion

cursor: pointer;

&[readonly] {
cursor: default;
}
Expand Down
1 change: 1 addition & 0 deletions packages/elements/src/select/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export class Select extends ControlElement implements MultiValue {
right: 0;
bottom: 0;
left: 0;
cursor: pointer;
}
#select {
position: absolute;
Expand Down
1 change: 0 additions & 1 deletion packages/halo-theme/src/custom-elements/ef-select.less
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
}
}

cursor: pointer;

[part=list] {
color: @control-text-color;
Expand Down
2 changes: 2 additions & 0 deletions packages/solar-theme/src/custom-elements/ef-select.less
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

// #region - Extend from ef-button styles
&:extend(:host);
// pointer cursor style would be applied internally to trigger element instead
cursor: unset;
&:not([readonly]):hover {
&:extend(:host:hover);
}
Expand Down

0 comments on commit eff8a75

Please sign in to comment.