Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(counter): change width height, font size, bg color to proper style #117

Merged
merged 9 commits into from
Dec 16, 2021

Conversation

bualoy-napat
Copy link
Collaborator

Description

This change is about the theme of the counter that had conflicting representations in Figma. Then, I decided to change the style of the counter to follow the finalized style on Figma. This change also fixed width, height, font size, and padding to make the counter represent on combo box and tree select correctly.

Fixes # (issue)
ELF-1693

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@bualoy-napat bualoy-napat added the bug Something isn't working label Dec 9, 2021
@bualoy-napat bualoy-napat self-assigned this Dec 9, 2021
@Sarin-Udompanish Sarin-Udompanish merged commit 8388eee into develop Dec 16, 2021
@Sarin-Udompanish Sarin-Udompanish deleted the fix/update-style-counter-color branch December 16, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants