Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(solar-theme): add overrided active styles of button #123

Merged
merged 2 commits into from
Dec 16, 2021
Merged

fix(solar-theme): add overrided active styles of button #123

merged 2 commits into from
Dec 16, 2021

Conversation

Sarin-Udompanish
Copy link
Collaborator

@Sarin-Udompanish Sarin-Udompanish commented Dec 14, 2021 •
edited
Loading

Description

No button pressed state is applied to the button. You can see the difference with v1

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Sarin-Udompanish Sarin-Udompanish merged commit 8fe0ad0 into develop Dec 16, 2021
@Sarin-Udompanish Sarin-Udompanish deleted the fix/coral-button-no-pressed-state-is-applied branch December 16, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bualoy-napat bualoy-napat bualoy-napat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sarin-Udompanish @bualoy-napat