Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): set width 100% on tree item so custom renderer can do layout #125

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

dtanp-rft
Copy link
Collaborator

Description

[part=label] in ef-tree-item not set width to 100% so when using custom renderer, we can't layup element easily e.g. using flex.

For example, https://codepen.io/dtanp-rft/pen/BawpzRv
It's not possible for space-between to work if width is not set to 100%.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@dtanp-rft dtanp-rft merged commit e6188b2 into develop Dec 16, 2021
@dtanp-rft dtanp-rft deleted the fix/tree-custom-render-layout branch December 16, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants