Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enter should not check/uncheck radio and checkbox #157

Merged
merged 6 commits into from
Jan 11, 2022
Merged

fix: Enter should not check/uncheck radio and checkbox #157

merged 6 commits into from
Jan 11, 2022

Conversation

wsuwt
Copy link
Collaborator

@wsuwt wsuwt commented Jan 11, 2022 •
edited
Loading

Description

See,

Native checkbox and radio button can only be toggle via Space key.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Jidapa-Pai
Copy link
Contributor

Tested on Windows, everything looks fine. It works same as native element behavior.

@wsuwt wsuwt merged commit 0d9d03a into develop Jan 11, 2022
@wsuwt wsuwt deleted the Enter-should-not-check/uncheck-radio-and-checkbox branch January 11, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsuwt @Jidapa-Pai @phetw