fix(utils): improve svg security #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsuwt
reviewed
Jun 1, 2022
fix(svg-loader): use responseXML for added security
Deploying with
|
| Latest commit: |
87aff94
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a4a3c522.refinitiv-ui.pages.dev |
|
I've removed the previous code duplication and shifted logic into a separate Using @goremikins suggestion of |
goremikins
previously approved these changes
Jun 1, 2022
TremayneChrist
changed the title
wsuwt
approved these changes
Jun 2, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
Bangkok team has already tried to hack the code but nobody is succeeding. I think we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds patch to strip event attributes from any SVG body