Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect type delcaration path #370

Merged
merged 2 commits into from
Jun 20, 2022
Merged

fix: incorrect type delcaration path #370

merged 2 commits into from
Jun 20, 2022

Conversation

wsuwt
Copy link
Collaborator

@wsuwt wsuwt commented Jun 20, 2022

Description

This fix to to point TypeScript to type declaration correctly. Previous TypedVersion string pattern requires *.js extension which we do not have in exported path.

Fixes https://jira.refinitiv.com/browse/ELF-1860

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@wsuwt wsuwt added the bug Something isn't working label Jun 20, 2022
@wsuwt wsuwt self-assigned this Jun 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2c587c4
Status: ✅  Deploy successful!
Preview URL: https://d12de74d.refinitiv-ui.pages.dev
Branch Preview URL: https://fix-ts-export-path.refinitiv-ui.pages.dev

View logs

@wsuwt wsuwt merged commit 4b40823 into v6 Jun 20, 2022
@wsuwt wsuwt deleted the fix/ts-export-path branch June 20, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants