Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): create bare entrypoint to reduce bundle size #687

Merged
merged 22 commits into from
May 22, 2023

Conversation

Theeraphat-Sorasetsakul
Copy link
Collaborator

Description

Provide new entrypoint of ef-chart for app to optimize size of bundle

Fixes # (STG-421)

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 94889d9
Status: ✅  Deploy successful!
Preview URL: https://1cb0210e.refinitiv-ui.pages.dev
Branch Preview URL: https://chart-new-entrypoint.refinitiv-ui.pages.dev

View logs

wsuwt and others added 4 commits May 17, 2023 15:49
* test: increase mocha test timeout to 5 sec (#642)

* refactor(combo-box): use conditional template rendering instead of `hidden` attribute to hide clear icon (#602)

* fix(calendar): unexpected `blur` event fired when view changes (#655)

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

* docs: fix wrong item type of multiple list demo (#666)

* fix: add checkbox theme to item element to made it render on multiple mode

* fix: revert import checkbox theme

* docs: fix wrong item type of multiple list demo

* docs: fix generated `tree-item` type in demo page

---------

Co-authored-by: Sarin Udompanish <[email protected]>
Co-authored-by: wsuwt <[email protected]>

* chore(deps): bump yaml from 2.2.1 to 2.2.2 (#664)

Bumps [yaml](https://github.com/eemeli/yaml) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/eemeli/yaml/releases)
- [Commits](eemeli/yaml@v2.2.1...v2.2.2)

---
updated-dependencies:
- dependency-name: yaml
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* docs: notify user to reload page after switch theme (#670)

* docs: notify user to reload page after switch theme

* Update documents/src/pages/build-app/theme-switching.md

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

---------

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* chore: add black duck workflow (#667)

* feat: remove font bold (#665)

* feat: remove font bold

* fix: native header element font-weight

* docs: fix font-weight in demo pages

* chore: update LICENSE removing `bold` font reference

* fix: remove font bold from elements

---------

Co-authored-by: Sarin Udompanish <[email protected]>
Co-authored-by: wsuwt <[email protected]>
Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* feat: export `nothing` value from `lit` (#671)

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

* docs: add file extension to dynamic import of theme switching example (#683)

* test: convert resize observer loop error to warning (#679)

* feat(test-helper): add mocha util converting resize observer loop error to warning

* test(canvas): apply observer loop handler

* test(clock): apply observer loop handler

* test(heatmap): apply observer loop handler

* test(interactive-chart): apply observer loop handler

* test(layout): apply observer loop handler

* test(notification): apply observer loop handler

* test(overlay): apply observer loop handler

* test(sparkline): apply observer loop handler

* test(swing-gauge): apply observer loop handler

* test(tornado-chart): apply observer loop handler

* test(test-helpers): add test for resize observer loop handler

* refactor(test-helpers): refactor resize observer loop handler to test helper's side effect

* test(elements): remove resize observer loop handler import

* refactor(test-helpers): cleanup export

* refactor(test-helpers): fix code smell

---------

Co-authored-by: Wasuwat Limsuparhat <[email protected]>

* fix: responsive element not work in ios 15 and below (#680)

Co-authored-by: wattachai <[email protected]>

* chore(release): publish [skip ci]

 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]
 - @refinitiv-ui/[email protected]

* test: fix to using web/test-runner syntax

* test: fix ignore coverage syntax

* chore: replace web dev server with vite (#681)

* chore: update demo page

* chore: remove all web-dev-server config and update demo

* chore: add missing demo css file to heatmap demo

* chore: remove native button demo

* chore: change ignore eslint in demo block

* chore: remove visibility hidden from demo block

---------

Co-authored-by: Sarin-Udompanish <[email protected]>

* refactor: chart bare entry PR

* test: update chart snapshot

* docs(chart): revert Type back to support jsdoc

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: wattachai <[email protected]>
Co-authored-by: refinitiv-ui-dev <[email protected]>
Co-authored-by: Sarin-Udompanish <[email protected]>
Co-authored-by: Sarin Udompanish <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Napat Bualoy <[email protected]>
Co-authored-by: Theeraphat Sorasetsakul <[email protected]>
Co-authored-by: Theeraphat-Sorasetsakul <[email protected]>
@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul changed the base branch from migrate-chartjs4 to v7 May 18, 2023 03:59
@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul changed the base branch from v7 to migrate-chartjs4 May 18, 2023 03:59
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
5.0% 5.0% Duplication

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul merged commit 7facd35 into migrate-chartjs4 May 22, 2023
@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul deleted the chart/new-entrypoint branch May 22, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants