Snap to grid #21
Open
Snap to grid #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snap resize to predefined grid size.
| var offset = (axis == 'x') ? start - e.clientX : start - e.clientY; | ||
|
|
||
| // bind resize to grid | ||
| var gridX = scope.rGrid[0] || 1, |
There was a problem hiding this comment.
If r-grid isn't set on the resizable element, this logs an error. Instead maybe use:
var gridX = scope.rGrid ? scope.rGrid[0] : 1,
gridY = scope.rGrid ? scope.rGrid[1] : 1;
|
This looks great! I added one comment, but couldn't find any more problems. Swap that out and we can merge :) |
Added parameter "rLimitResizeTo" to limit resize step.
|
Hi, any update when this will be merged? I really need this feature. |
|
This would be awesome. Any chance of this getting merged? |
gehrmanng
pushed a commit
to gehrmanng/angular-resizable
that referenced
this pull request
Jun 26, 2016
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snap resize to predefined grid size.