Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport checked pow #134

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Backport checked pow #134

merged 2 commits into from
Mar 19, 2024

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Mar 19, 2024 •
edited
Loading

PR Description

Backports JuliaLang#52849.

Only conflicts were in the compiler/ssair tests, which now pass:

julia> Base.runtests(["compiler/ssair"])
Running parallel tests with:
  nworkers() = 1
  nthreads() = 1
  Sys.CPU_THREADS = 4
  Sys.total_memory() = 64.000 GiB
  Sys.free_memory() = 21.334 GiB

Test       (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
compiler/ssair  (1) |        started at 2024-03-19T00:05:07.301
compiler/ssair  (1) |     3.35 |   0.03 |  0.9 |     320.90 |   346.09

Test Summary: | Pass  Total  Time
  Overall     |  140    140  4.0s
    SUCCESS

Checklist

Requirements for merging:

@NHDaly @vtjnash
@aviatesk @d-netto
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)
62f7075 
Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
@d-netto d-netto requested review from NHDaly and kpamnany March 19, 2024 03:06
NHDaly
NHDaly approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you

@d-netto d-netto merged commit 6cd7ce2 into v1.10.2+RAI Mar 19, 2024
5 checks passed
@d-netto d-netto deleted the dcn-backport-checked_pow branch March 19, 2024 19:37
@d-netto d-netto added the port-to-v1.10 This change should apply to Julia v1.10 builds label Mar 19, 2024
@d-netto d-netto removed the port-to-v1.10 This change should apply to Julia v1.10 builds label Apr 16, 2024
d-netto added a commit that referenced this pull request Apr 16, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
4ccc567 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request Apr 23, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
d3290df 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request Apr 24, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
aeb863d 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request Apr 30, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
7bc992d 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request Apr 30, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
7a29fdc 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request May 2, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
60ac1c4 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request May 9, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
3d94ade 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request May 19, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
d9223a3 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request May 26, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
10e4c62 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request May 28, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
8125f4b 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
DelveCI pushed a commit that referenced this pull request May 29, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
a9000b8 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
Drvi added a commit that referenced this pull request Jun 7, 2024
@d-netto @NHDaly
@vtjnash @aviatesk @Drvi
Add Base.checked_pow(x,y) to Base.Checked library (JuliaLang#52849)…
21a3307 
… (#134)

Fixes JuliaLang#52262.

Performs `^(x, y)` but throws OverflowError on overflow.

Example:
```julia
julia> 2^62
4611686018427387904

julia> 2^63
-9223372036854775808

julia> checked_pow(2, 63)
ERROR: OverflowError: 2147483648 * 4294967296 overflowed for type Int64
```

Co-authored-by: Nathan Daly <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Shuhei Kadowaki <[email protected]>
Co-authored-by: Tomáš Drvoštěp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHDaly NHDaly NHDaly approved these changes

@kpamnany kpamnany kpamnany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-netto @NHDaly @kpamnany @Drvi