Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architectury API is incompatible with GC Free Serializer #219

Open
3 tasks done
ghost opened this issue May 29, 2023 · 6 comments
Open
3 tasks done

Architectury API is incompatible with GC Free Serializer #219

ghost opened this issue May 29, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented May 29, 2023

Describe the bug

I see an error in the log when running the game with GC Free Serializer enabled in my instance, but so far I can't pinpoint exactly which mod is causing the error. If I leave only C2M then GC Free Serializer works fine.

To Reproduce
Steps to reproduce the behavior:

  1. Enable GC Free Serializer
  2. Start a game

Expected behavior
At least the game was expected to load...

Runtime info:

  • OS: Windows 10 22H2 64Bit
  • Minecraft version: 1.19.4
  • Mod version: 0.2.0-alpha.10.55
  • Mod branch: default

Crash reports / logs
latest.log

Other mods
Modlist
Checklist

  • I am using the official version of the mod.
  • I tried the latest development version but the issue persists.
  • I searched for similar open issues and could not find an existing bug report on this.
@ghost ghost added the bug Something isn't working label May 29, 2023
@ghost ghost changed the title [Incompatibility] [Incompatibility] With mod xxxx May 29, 2023
@ghost
Copy link
Author

ghost commented May 29, 2023

Damn, I tried to separately combine C2M with each mod from the list and everything works, but if I combine all the mods in my instance, the error appears until I turn off GC Free Serializer.

@toinouH
Copy link
Contributor

toinouH commented May 29, 2023

Could you try without memoryfixleak ?
Thank you.

@ghost
Copy link
Author

ghost commented May 29, 2023

Could you try without memoryfixleak ? Thank you.

If only Memory Leak Fix are removed from the entire list of mods, then the game starts and works normally, but also, if install only Memory Leak Fix and C2M (with enabled GC Free Serializer), then this also works...

https://gist.github.com/AlexChevios/9190a9c4d9eeacaebb9525997a858726

@ghost
Copy link
Author

ghost commented May 30, 2023

I jumped to conclusions. If I remove Memory Leak Fix when C2M GC Free Serializer is enabled, then the game loads normally, but when I try to create a world, the game crashes:

latest.log

crash-2023-05-30_12.03.27-server.txt

@ishland
Copy link
Collaborator

ishland commented May 30, 2023

It appears that the compatibility for architectury-api is impossible if anything uses ChunkEvent.SAVE_DATA in the API.
https://github.com/architectury/architectury-api/blob/ee23ba2cb83cb8bb760419848bb18c94940b797d/fabric/src/main/java/dev/architectury/mixin/fabric/MixinChunkMap.java#L43-L50
However with a quick GitHub code search it appears that almost nobody is using that API.
Might worth opening an issue on their side.

@ghost
Copy link
Author

ghost commented May 30, 2023

Okay, I'll notify the author of Architectury API.

@ishland ishland changed the title [Incompatibility] With mod xxxx Architectury API is incompatible with GC Free Serializer Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants