Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer tokens from unfrozen to operational balance #70

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Art17
Copy link
Contributor

@Art17 Art17 commented May 26, 2019

If you create new CLI commands, use this pull request description as
template — #3. Else remove this line.

Jira references

Description

Transfer available tokens from unfrozen reputational balance to operational balance (executable only on the machine which runs the node) — remme node-account transfer-tokens-from-unfrozen-to-operational.

Arguments Type Required Description
amount Integer Yes Amount to transfer.
$ remme node-account transfer-tokens-from-unfrozen-to-operational
{
    "result": {
        "batch_id": "045c2b7c43a7ca7c3dc60e92714c03265572a726d1fae631c39a404eaf97770e3f6a7a8c35c86f6361afb2e4f12b4a17d71a66a19158b62f30531ab32b62f06f"
    }
}

@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #70 into develop will decrease coverage by 0.48%.
The diff coverage is 72.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #70      +/-   ##
===========================================
- Coverage    94.15%   93.66%   -0.49%     
===========================================
  Files           61       61              
  Lines         1300     1327      +27     
===========================================
+ Hits          1224     1243      +19     
- Misses          76       84       +8
Impacted Files Coverage Δ
cli/node_account/forms.py 100% <100%> (ø) ⬆️
cli/node_account/interfaces.py 55.55% <50%> (-1.59%) ⬇️
cli/node_account/service.py 88.23% <66.66%> (-4.63%) ⬇️
cli/node_account/cli.py 87.01% <72.22%> (-4.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94cc09f...7dfa36e. Read the comment docs.

@Art17 Art17 requested review from dmytrostriletskyi and anastasiia-bilova and removed request for dmytrostriletskyi May 26, 2019 12:52
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
cli/node_account/interfaces.py Show resolved Hide resolved
README.md Show resolved Hide resolved
expected_error = {
'errors': {
'amount': [
f'Amount must be greater than 0.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f'Amount must be greater than 0.',
'Amount must be greater than 0.',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants