fix(server/main): Cannot find account #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, we have a update in the works currently so pull requests will not be merged as it is a LUA rewrite with UI improvements. Also this is not a fix, GetPlayerObject has 2 parameters a source which will accept the initiators source. This is only used to notify the player that the player they are looking for cannot be found if that is the case. Their also is the id parameter which can be a player source or a player identifier. which is why it will then call GetPlayerObjectFromID if Player is not defined. The changes will always return the initiators player object which is not intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetPlayerObject requires source and is currently getting ID