Skip to content

Commit

Permalink
Merge pull request #423 from Renumics/feature/add-datasource-type-to-…
Browse files Browse the repository at this point in the history
…trace

add missing newline to event details
  • Loading branch information
neindochoh authored Feb 14, 2024
2 parents fd6931e + 6745a5a commit a0ca67b
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions renumics/spotlight/reporting.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from loguru import logger

from renumics.spotlight import __version__
from renumics.spotlight.data_source import DataSource
from renumics.spotlight.plugin_loader import load_plugins
from renumics.spotlight.settings import settings

Expand Down Expand Up @@ -190,7 +191,9 @@ def _sanitize_traceback_exception(exc: traceback.TracebackException) -> None:
_sanitize_traceback_exception(exc.__context__)


def emit_exception_event(path: Optional[str] = None) -> None:
def emit_exception_event(
path: Optional[str] = None, datasource: Optional[DataSource] = None
) -> None:
"""
Emit an exception event.
"""
Expand All @@ -200,10 +203,9 @@ def emit_exception_event(path: Optional[str] = None) -> None:
traceback_exc = traceback.TracebackException.from_exception(exc)
_sanitize_traceback_exception(traceback_exc)

if path:
detail = f"Path: {path}\n" + "\n\n".join(traceback_exc.format())
else:
detail = "Path: None\n" + "\n\n".join(traceback_exc.format())
detail = f"Path: {path}\nDatasource: {type(datasource).__name__}\n" + "\n\n".join(
traceback_exc.format()
)

report_event(
{
Expand Down

0 comments on commit a0ca67b

Please sign in to comment.