Add caching on client id for purchases #1551
Open
+50
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
koutst
commented
Apr 25, 2024
•
koutst
commented
- To prevent accidental double purchases such as tipping.
- All requests to this endpoint will require a client id.
koutst
changed the title
gzurowski
reviewed
Apr 29, 2024
src/purchase/views/purchase_view.py
Outdated
Comment on lines
81
to
90
| cached_client_id = cache.get(f"purchase_client_id_{client_id}") | ||
| if cached_client_id: | ||
| return Response( | ||
| { | ||
| "detail": "This purchase has already been processed", | ||
| }, | ||
| status=400, | ||
| ) | ||
|
|
||
| cache.set(f"purchase_client_id_{client_id}", True, timeout=60) |
There was a problem hiding this comment.
Nit: It might be better to implement idempotent behavior and return the original transaction with a 2xx series response code.
koutst
force-pushed
the
check-client-id-on-create-purchase
branch
from
8ccf11c
to
0112cfc
Compare
|
Paper contributions front end needs to be updated before deploying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.