Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce signals for registry update tasks #1918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gzurowski
Copy link
Member

Prevent multiple Elasticsearch reindex requests on the same model instance within the specified DEBOUNCE_SIGNAL_PERIOD.

The following screenshot shows updates triggered for one paper within the same second:
image

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.26%. Comparing base (a297f95) to head (481824b).

Files with missing lines Patch % Lines
src/search/celery.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1918   +/-   ##
=======================================
  Coverage   68.25%   68.26%           
=======================================
  Files        1149     1149           
  Lines       27155    27160    +5     
=======================================
+ Hits        18535    18540    +5     
  Misses       8620     8620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Prevent multiple Elasticsearch reindex requests on the same
model within the specified `DEBOUNCE_SIGNAL_PERIOD`.
@gzurowski gzurowski force-pushed the es-debounce-processor-signals branch from c70f4b7 to 481824b Compare October 16, 2024 12:54
Copy link

sonarcloud bot commented Oct 16, 2024

@gzurowski
Copy link
Member Author

Verified in staging that only one signal gets processed for multiple save operations on the same papers (without the change, updating the title of a paper triggered three signals).

image

@gzurowski gzurowski marked this pull request as ready for review October 16, 2024 13:32
@gzurowski gzurowski requested a review from a team as a code owner October 16, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants