[final] add should purchase promo product #25

aboedo · 2020-01-23T21:51:46Z

Description

https://trello.com/c/emjo2Nlf

Related PR: RevenueCat/react-native-purchases#98

~~This is still missing cleanup work, but it's functional.~~

Changes summary:

bumped iOS sdk to v3.0.2, updated path to Purchases.framework in script
added method makeDeferredPurchase, to be called by client apps when they're ready to make a promotional purchase.
added method shouldPurchasePromoProduct, called by the SDK when it detects that a promotional purchase should be made.
added addShouldPurchasePromoProductListener and removeShouldPurchasePromoProductListener, to be called by client apps so they can set up listeners. They will get a function that they call to trigger the purchase on our side, which they can call whenever the app is ready to make the purchase.

Code flow:

client calls set up purchases.
this sets up a callback id, to be used later when promo purchases are detected.
client registers listeners for when promo purchases are ready to be made. listeners are functions, and they should internally call makeDeferredPurchase();. listeners won't be executed until promo purchases are detected.
we store the listeners (clients can remove them if needed).
app is used, time passes
promo purchase is detected by app
sdk calls shouldPurchasePromoProduct. we store a callback id to identify the exact call.
sdk notifies client that it's ready to make a deferred purchase. Listeners are notified, they execute client code and call makeDeferredPurchase()
makeDeferredPurchase gets the callback id to identify the exact call, and calls makeDeferredPurchase on the sdk.

…hases-framework.sh after the carthage archive updates.

…duct, although they don't do anything yet.

…ature calling of the should purchase method

aboedo · 2020-01-23T22:09:33Z

scripts/download-purchases-framework.sh

@@ -28,7 +28,7 @@ curl -sSL $URL > temp.zip
 # In some cases the temp folder can not be created by unzip, https://github.com/RevenueCat/react-native-purchases/issues/26
 mkdir -p temp
 unzip -o temp.zip -d temp
-mv temp/Purchases.framework ./Purchases.framework
+mv temp/Carthage/Build/iOS/Purchases.framework ./Purchases.framework


new path in 3.0.2

aboedo · 2020-01-23T22:10:06Z

src/ios/CDVPurchasesPlugin.h

@@ -22,6 +22,7 @@
 - (void)createAlias:(CDVInvokedUrlCommand *)command;
 - (void)identify:(CDVInvokedUrlCommand *)command;
 - (void)reset:(CDVInvokedUrlCommand *)command;
+- (void)setupShouldPurchasePromoProductCallback:(CDVInvokedUrlCommand *)command;


this is so that we get a different callback id, which we can store and use later when notifying javascript

aboedo · 2020-01-23T22:33:07Z

src/plugin/plugin.ts

+    return false;
+  }
+
+  private static setupShouldPurchasePromoProductCallback() { 


we weren't using private functions here, but I figured it wouldn't hurt

aboedo · 2020-01-23T23:46:38Z

src/plugin/plugin.ts

+   */
+  public static addShouldPurchasePromoProductListener(shouldPurchasePromoProductListener: ShouldPurchasePromoProductListener): void { 
+    if (typeof shouldPurchasePromoProductListener !== "function") {
+      throw new Error("addPurchaserInfoUpdateListener needs a function");


Oops, fixing

Cool. I commented on my review on this before seeing this

@vegaro https://github.com/RevenueCat/react-native-purchases/pull/98/files#diff-f41e9d04a45c83f3b6f6e630f10117feR546 LOL 😂 copy/paste kings over here. I'll make a PR for that one as well.

vegaro

Why did src/ios/Purchases.framework/Purchases get removed??

vegaro · 2020-01-23T23:08:35Z

src/plugin/plugin.ts

+  }
+
+  private static setupShouldPurchasePromoProductCallback() { 
+    window.cordova.exec(


Doesn't Android crash because setupShouldPurchasePromoProductCallback doesn't exist in the Android code?

good catch. I'll fix it and update. I forgot to test on android (hides in shame)

vegaro · 2020-01-24T00:01:18Z

src/plugin/plugin.ts

+    return false;
+  }
+
+  private static setupShouldPurchasePromoProductCallback() { 


vegaro · 2020-01-24T00:06:37Z

src/plugin/plugin.ts

+  private static setupShouldPurchasePromoProductCallback() { 
+    window.cordova.exec(
+      (callbackResult: any) => {
+          const callbackID = callbackResult.callbackID;


This two lines could be removed with:
({callbackID}:{callbackID: number}) => {

cool! didn't know that! I'll update

aboedo · 2020-01-24T15:22:31Z

I'm not sure what's going on with src/ios/Purchases.framework.Purchases on github. I see it locally, and it was modified on this commit:
https://github.com/revenuecat/cordova-plugin-purchases/commits/438fc31d47d7933b53b9c81567aa3ad7f520ea1e
however, git show 438fc31d47d7933b53b9c81567aa3ad7f520ea1e shows it as modified

diff --git a/src/ios/Purchases.framework/Purchases b/src/ios/Purchases.framework/Purchases
index 7899882..e41cb3f 100755
Binary files a/src/ios/Purchases.framework/Purchases and b/src/ios/Purchases.framework/Purchases differ

I tried clean-cloning and checking out the branch and I do get the file, so I'm not sure what's going on. I'll do some further digging, but right now it seems that Github is the only one that sees the file as removed.

aboedo · 2020-01-24T15:44:24Z

you can even see the file on the branch: https://github.com/RevenueCat/cordova-plugin-purchases/blob/feature/addShouldPurchasePromoProduct/src/ios/Purchases.framework/Purchases

So I really think this is a github bug. If I try removing the file on my local repo and check git diff, it does show that I'm removing it.

aboedo · 2020-01-24T15:44:45Z

@vegaro would you mind doing a sanity check by checking out the branch?

aboedo · 2020-01-24T18:11:32Z

src/android/PurchasesPlugin.java

@@ -156,6 +156,11 @@ private void setAutomaticAppleSearchAdsAttributionCollection(boolean enabled, Ca
        // NOOP
    }

+    @PluginAction(thread = ExecutionThread.WORKER, actionName = "setupShouldPurchasePromoProductCallback")
+    private void setupShouldPurchasePromoProductCallback(CallbackContext callbackContext) {
+        // NOOP


wild violation of Interface Segregation Principle, but I think it's okay? I copied it from line 156.
other ideas would be to have the javascript side decide (which isn't ideal), or to somehow split interfaces, which might be too much work for too little gain.

I think this is better too

aboedo · 2020-01-24T18:12:04Z

@vegaro ready for another pass

aboedo added 15 commits January 20, 2020 16:12

added DS_Store to .gitignore

18f9105

bumped ios sdk to 3.0.2

438fc31

updated the path of Purchases.framework location in the download-purc…

9f4a428

…hases-framework.sh after the carthage archive updates.

added ability to store and remove listeners of shouldPurchasePromoPro…

dd7a4ab

…duct, although they don't do anything yet.

added delegate method for shouldPurchasePromoProduct

b29453f

added makeDeferredPurchase

df55368

added setupShouldPurchasePromoProductCallback

7aa9d28

WIP small fix, added calling the setup method

4511169

replaced the window event with actually calling makeDeferredPurchase

2b68250

built the plugin and updated js files

147e7b8

fixed a bug where the wrong callback id was being passed

9965b51

fixed issue where the callback id wasn't correctly passed, fixed prem…

8fb1b14

…ature calling of the should purchase method

small updates to callback

8c204b7

removed commented code

4eba5c1

lint update

2e093ed

aboedo self-assigned this Jan 23, 2020

cleanup

2260207

aboedo changed the title ~~[wip] add should purchase promo product~~ [final] add should purchase promo product Jan 23, 2020

aboedo requested a review from vegaro January 23, 2020 22:34

aboedo commented Jan 23, 2020

View reviewed changes

vegaro requested changes Jan 24, 2020

View reviewed changes

vegaro reviewed Jan 24, 2020

View reviewed changes

aboedo added 2 commits January 24, 2020 11:47

fix copy/paste method name in error message

58ae273

more updates from pr comments

196f9ac

fixed path for the framework again

9da9427

forgot about android! added a NOOP method in android

dc25d08

aboedo commented Jan 24, 2020

View reviewed changes

aboedo requested a review from vegaro January 24, 2020 18:11

vegaro approved these changes Jan 25, 2020

View reviewed changes

aboedo merged commit 36aa716 into master Jan 27, 2020

aboedo deleted the feature/addShouldPurchasePromoProduct branch January 27, 2020 13:41

aboedo mentioned this pull request Feb 3, 2020

[final] bump: version 1.0.5 #27

Merged

aboedo mentioned this pull request Apr 8, 2020

feat(purchases): update to [email protected] danielsogl/awesome-cordova-plugins#3371

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[final] add should purchase promo product #25

[final] add should purchase promo product #25

aboedo commented Jan 23, 2020 •

edited

Loading

aboedo Jan 23, 2020

aboedo Jan 23, 2020

aboedo Jan 23, 2020

vegaro Jan 24, 2020

aboedo Jan 23, 2020

vegaro Jan 24, 2020 •

edited

Loading

aboedo Jan 24, 2020

vegaro left a comment

vegaro Jan 23, 2020

aboedo Jan 24, 2020

vegaro Jan 24, 2020

vegaro Jan 24, 2020

aboedo Jan 24, 2020

aboedo commented Jan 24, 2020

aboedo commented Jan 24, 2020

aboedo commented Jan 24, 2020

aboedo Jan 24, 2020

vegaro Jan 24, 2020

aboedo commented Jan 24, 2020

[final] add should purchase promo product #25

[final] add should purchase promo product #25

Conversation

aboedo commented Jan 23, 2020 • edited Loading

Description

Changes summary:

Code flow:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vegaro Jan 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vegaro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aboedo commented Jan 24, 2020

aboedo commented Jan 24, 2020

aboedo commented Jan 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aboedo commented Jan 24, 2020

aboedo commented Jan 23, 2020 •

edited

Loading

vegaro Jan 24, 2020 •

edited

Loading