Skip to content

Commit

Permalink
extract constant
Browse files Browse the repository at this point in the history
  • Loading branch information
vegaro committed Oct 20, 2023
1 parent 83fee6f commit 5aba1c9
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ private object Template4UIConstants {
val packageHorizontalSpacing = 8.dp
val checkmarkSize = 18.dp
const val fadedColorOpacity = 0.3f
const val maxPackagesToDisplay = 3f
}

@Composable
Expand Down Expand Up @@ -176,7 +177,7 @@ private fun ColumnScope.Packages(
state,
packageInfo,
viewModel,
if (numberOfPackages <= 3) {
if (numberOfPackages <= Template4UIConstants.maxPackagesToDisplay) {
Modifier.weight(1f)
} else {
Modifier.width(packageWidth)
Expand All @@ -196,9 +197,8 @@ private fun BoxWithConstraintsScope.packageWidth(numberOfPackages: Float): Dp {
@SuppressWarnings("MagicNumber")
private fun packagesToDisplay(numberOfPackages: Float): Float {
// TODO-PAYWALLS: Implement different counts for different screen sizes
val desiredCount = 3.5f
val maximumPackagesToDisplay = 3f
return min(min(desiredCount, numberOfPackages), maximumPackagesToDisplay)
val desiredCount = Template4UIConstants.maxPackagesToDisplay + 0.5f
return min(min(desiredCount, numberOfPackages), Template4UIConstants.maxPackagesToDisplay)
}

@SuppressWarnings("LongMethod")
Expand Down

0 comments on commit 5aba1c9

Please sign in to comment.