Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strings module #1097

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Remove strings module #1097

merged 2 commits into from
Jun 27, 2023

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Jun 26, 2023

Before:
module_graph17532763803210947013

After:
module_graph7368127155832297177

@vegaro vegaro requested a review from a team June 26, 2023 15:34
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1097 (71e7e8f) into main (eb547e3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   85.88%   85.88%           
=======================================
  Files         179      179           
  Lines        6364     6364           
  Branches      876      876           
=======================================
  Hits         5466     5466           
  Misses        556      556           
  Partials      342      342           
Impacted Files Coverage Δ
...revenuecat/purchases/strings/AttributionStrings.kt 0.00% <ø> (ø)
...com/revenuecat/purchases/strings/BillingStrings.kt 0.00% <ø> (ø)
...m/revenuecat/purchases/strings/ConfigureStrings.kt 0.00% <ø> (ø)
...evenuecat/purchases/strings/CustomerInfoStrings.kt 0.00% <ø> (ø)
...in/java/com/revenuecat/purchases/strings/Emojis.kt 0.00% <ø> (ø)
...om/revenuecat/purchases/strings/IdentityStrings.kt 0.00% <ø> (ø)
...com/revenuecat/purchases/strings/NetworkStrings.kt 0.00% <ø> (ø)
...om/revenuecat/purchases/strings/OfferingStrings.kt 0.00% <ø> (ø)
...at/purchases/strings/OfflineEntitlementsStrings.kt 0.00% <ø> (ø)
...om/revenuecat/purchases/strings/PurchaseStrings.kt 0.00% <ø> (ø)
... and 2 more

Copy link
Contributor

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 excited about this.

@vegaro vegaro mentioned this pull request Jun 26, 2023
@vegaro vegaro merged commit b4434aa into main Jun 27, 2023
@vegaro vegaro deleted the cesar/sdk-3201-remove-strings-module branch June 27, 2023 12:17
tonidero added a commit that referenced this pull request Jul 12, 2023
**This is an automatic release.**

### New Features
* `Trusted Entitlements`: made API stable (#1105) via NachoSoto
(@NachoSoto)

This new feature prevents MitM attacks between the SDK and the
RevenueCat server.
With verification enabled, the SDK ensures that the response created by
the server was not modified by a third-party, and the entitlements
received are exactly what was sent.
This is 100% opt-in. `EntitlementInfos` have a new `VerificationResult`
property, which will indicate the validity of the responses when this
feature is enabled.

```kotlin
fun configureRevenueCat() {
    val configuration = PurchasesConfiguration.Builder(context, apiKey)
        .entitlementVerificationMode(EntitlementVerificationMode.INFORMATIONAL)
        .build()
    Purchases.configure(configuration)
}
```
### Experimental features
* Add await offerings (#1096) via Cesar de la Vega (@vegaro)
### Bugfixes
* Fix issue updating customer info on app open (#1128) via Toni Rico
(@tonidero)
### Dependency Updates
* Bump fastlane-plugin-revenuecat_internal from `13773d2` to `b2108fb`
(#1095) via dependabot[bot] (@dependabot[bot])
### Other Changes
* [PurchaseTester] Add option to purchase an arbitrary product id
(#1099) via Mark Villacampa (@MarkVillacampa)
* Fix release path after module refactor (#1129) via Toni Rico
(@tonidero)
* Fix load shedder integration tests (#1125) via Toni Rico (@tonidero)
* Trusted entitlements: New trusted entitlements signature format
(#1117) via Toni Rico (@tonidero)
* Fix integration tests and change to a different project (#1123) via
Toni Rico (@tonidero)
* Move files into src/main/kotlin (#1122) via Cesar de la Vega (@vegaro)
* Remove public module (#1113) via Cesar de la Vega (@vegaro)
* Remove common module (#1106) via Cesar de la Vega (@vegaro)
* Fix flaky integration tests: Wait for coroutines to finish before
continuing (#1120) via Toni Rico (@tonidero)
* Move amazon module into purchases (#1112) via Cesar de la Vega
(@vegaro)
* Trusted entitlements: Add IntermediateSignatureHelper to handle
intermediate signature verification process (#1110) via Toni Rico
(@tonidero)
* Trusted entitlements: Add Signature type to process new signature
response format (#1109) via Toni Rico (@tonidero)
* [EXTERNAL] Add `awaitCustomerInfo` / coroutines tests to
`TrustedEntitlementsInformationalModeIntegrationTest` (#1077) via
@pablo-guardiola (#1107) via Toni Rico (@tonidero)
* Remove feature:google module (#1104) via Cesar de la Vega (@vegaro)
* Remove identity module (#1103) via Cesar de la Vega (@vegaro)
* Remove subscriber attributes module (#1102) via Cesar de la Vega
(@vegaro)
* Delete utils module (#1098) via Cesar de la Vega (@vegaro)
* Remove strings module (#1097) via Cesar de la Vega (@vegaro)
* Update CHANGELOG.md to include external contribution (#1100) via Cesar
de la Vega (@vegaro)
* [EXTERNAL] Add missing `fetchPolicy` parameter to `awaitCustomerInfo`
API (#1086) via @pablo-guardiola (#1090) via Toni Rico (@tonidero)

---------

Co-authored-by: revenuecat-ops <[email protected]>
Co-authored-by: Toni Rico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants