-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create paywall tester app #1218
Create paywall tester app #1218
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1218 +/- ##
=========================================
Coverage 85.93% 85.93%
=========================================
Files 184 184
Lines 6269 6269
Branches 911 911
=========================================
Hits 5387 5387
Misses 536 536
Partials 346 346 ☔ View full report in Codecov by Sentry. |
compose true | ||
} | ||
composeOptions { | ||
kotlinCompilerExtensionVersion '1.4.0-alpha02' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a 1.5.3. IIRC, the Kotlin version is the reason why we are still in 1.4.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, according to https://developer.android.com/jetpack/androidx/releases/compose-kotlin, since we are using kotlin 1.8.0, we need to use 1.4.0-alpha02
. We could update to Kotlin 1.8.20 though... It just seems relatively recent. Thoughts on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah let's keep it and don't introduce more breaking points
Will merge this for now, can change this later as needed |
### Description This PR creates a new `Paywall tester` app in `examples/paywall-tester`. It also adds some basic initial UI (just the bottom tab) to mimic what we do in iOS. This app is part of the main project (not a separate project like MagicWeather/MagicWeatherCompose) ![Screenshot_20230904_122254](https://github.com/RevenueCat/purchases-android/assets/808417/4e3e36cd-bbe2-41e8-94b7-138e5f441f98)
Description
This PR creates a new
Paywall tester
app inexamples/paywall-tester
. It also adds some basic initial UI (just the bottom tab) to mimic what we do in iOS.This app is part of the main project (not a separate project like MagicWeather/MagicWeatherCompose)