-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor checking for available packages when creating package configuration #1307
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1307 +/- ##
=========================================
Coverage 85.06% 85.06%
=========================================
Files 193 193
Lines 6475 6475
Branches 942 942
=========================================
Hits 5508 5508
Misses 600 600
Partials 367 367 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much clearer, thanks!
...otlin/com/revenuecat/purchases/ui/revenuecatui/data/processed/PackageConfigurationFactory.kt
Outdated
Show resolved
Hide resolved
activelySubscribedProductIdentifiers = activelySubscribedProductIdentifiers, | ||
filter = packageIds, | ||
packageIdsInConfig = paywallData.config.packages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should rename the property packages
to packageIds
, even if the backend response remains the same... But that can be done separately if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will make things clearer. I will open a PR
…venuecatui/data/processed/PackageConfigurationFactory.kt Co-authored-by: Toni Rico <[email protected]>
…uration (#1307) Co-authored-by: Toni Rico <[email protected]>
There shouldn't be any behavior change, but this refactor makes it more clear what happens when none of the configured packages are available.