Paywalls: new PaywallActivityLauncher.launchIfNeeded methods

[NachoSoto]

This mimics the equivalent API in PaywallDialogOptions (and like in iOS).

[NachoSoto]

I've extracted these to share this code.

[NachoSoto]

Not sure if this is the best way to do this (exposing a suspend method). Feedback welcome.

[tonidero]

Hmm well, I imagine many people using activities/fragments are still not using coroutines, so offering a wrapper would be better... However, we would only be able to launch this coroutine from a global scope unless we ask developers to give us the launcher activity/fragment/view model to act as the scope...

I see 2 options here:

• Store a weak reference to the activity/fragment on the constructor so we can use that to launch the coroutine in that scope, and offer a non-coroutine version of these methods.
• Have a non-coroutine version of shouldDisplayPaywall that returns a callback so we can support this use case. We can wrap that callback in a coroutine for the current version, same way we do in CoroutinesExtensionsCommon.

Of those 2, I think the second might be the cleanest, but the first one is probably ok.
Any other ideas @vegaro ?

[NachoSoto]

Thanks! Just did option 2 :)

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (81f8c1d) 85.06% compared to head (766b678) 85.06%.
Report is 12 commits behind head on paywalls.

❗ Current head 766b678 differs from pull request most recent head 67726f5. Consider uploading reports for the commit 67726f5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##           paywalls    #1335   +/-   ##
=========================================
  Coverage     85.06%   85.06%           
=========================================
  Files           193      193           
  Lines          6475     6475           
  Branches        942      942           
=========================================
  Hits           5508     5508           
  Misses          600      600           
  Partials        367      367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tonidero]

Looks great!