Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paywalls
: template 4 #1349Paywalls
: template 4 #1349Changes from 21 commits
3ba1f7e
37d3b93
cb0b9b1
980967d
4f309e4
23b3f56
6c74c94
ef966cf
3e70d47
d9abf71
b59d5b4
61f9763
e1bce3c
fcb7094
167efc3
ae334e2
bd44551
b627a13
1b4ae0f
96df890
487d9fc
289253e
420958b
0d516e7
bb4d92b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this?
Also I wonder if this would be easier to find inside of
VariableDataProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes... Maybe would you add it as a extension there? The thing is that there's really no variable in this, that's why I didn't put it there. But I will move it as an extension for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be used for
{{ sub_relative_discount }}
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bit of delay when showing this takes a bit to load when there's rezising needed, so we might want to improve it in the future, maybe add an animation. I think it works for now and didn't want to spend much more time in this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬 Compose doesn't provide this? Yikes.
We should probably avoid using this for the most part because it's not accessibility friendly at all. This is the only place where I'm using it in iOS.
For now this solution is fine I think 👍🏻
A couple of suggested changes:
composables