Paywalls: decode empty images as null
#1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
nacho/pwl-340-template-3-top-margin-when-the-icon-isnt-present
branch
from
ea90b14
to
f0c1565
Compare
NachoSoto
commented
Oct 26, 2023
| @Test | ||
| fun `test PaywallData properties`() { | ||
| val json = loadJSON(PAYWALLDATA_SAMPLE1) | ||
|
|
||
| val paywall: PaywallData = Json.decodeFromString(json) |
There was a problem hiding this comment.
This was using Json without the same configuration that OfferingParser has.
NachoSoto
force-pushed
the
nacho/pwl-340-template-3-top-margin-when-the-icon-isnt-present
branch
from
f0c1565
to
b9bf98e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1398 +/- ##
============================================
- Coverage 84.46% 84.42% -0.04%
============================================
Files 196 197 +1
Lines 6584 6595 +11
Branches 957 959 +2
============================================
+ Hits 5561 5568 +7
- Misses 655 658 +3
- Partials 368 369 +1
☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Oct 27, 2023
vegaro
approved these changes
Oct 27, 2023
NachoSoto
deleted the
nacho/pwl-340-template-3-top-margin-when-the-icon-isnt-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to RevenueCat/purchases-ios#3195
This fixes issues with paywalls in the backend sending
""as images and the SDK trying to render an empty image and taking space: