SDK-3469 Remove deprecated purchase methods #1711

JayShortway · 2024-05-29T13:35:57Z

This PR leaves just purchase(PurchaseParams) as the only way to purchase.

Breaking changes

Removes purchasePackage()
Removes purchaseProduct()
Removes purchasePackageWith()
Removes purchaseProductWith()
Removes UpgradeInfo

Co-authored-by: Cesar de la Vega <[email protected]>

…InfoAPI. I should not blindly commit suggestions from GitHub :D

RevenueCat-Danger-Bot · 2024-05-29T13:36:30Z

	1 Message
📖	Size increase: 0.00 KB

Generated by 🚫 Danger

...es/purchase-tester/src/main/java/com/revenuecat/purchasetester/DeprecatedOfferingFragment.kt

JayShortway · 2024-05-29T13:38:52Z

purchases/src/testDefaults/kotlin/com/revenuecat/purchases/PurchasesTest.kt

@@ -114,7 +114,7 @@ internal class PurchasesTest : BasePurchasesTest() {
    // region purchasing

    @Test
-    fun `deprecated upgrade defaults ProrationMode to null if not passed`() {
+    fun `upgrade defaults ReplacementMode to WITHOUT_PRORATION if not passed`() {


I changed this test to assert the current behavior, assuming that that behavior is correct.

codecov · 2024-05-29T13:58:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (sdk-3465-support-bc7@ac81117). Learn more about missing BASE report.

Additional details and impacted files

@@                   Coverage Diff                   @@
##             sdk-3465-support-bc7    #1711   +/-   ##
=======================================================
  Coverage                        ?   82.86%           
=======================================================
  Files                           ?      220           
  Lines                           ?     7540           
  Branches                        ?     1066           
=======================================================
  Hits                            ?     6248           
  Misses                          ?      874           
  Partials                        ?      418

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tonidero · 2024-05-30T08:03:38Z

purchases/src/defaults/kotlin/com/revenuecat/purchases/Purchases.kt

-        "Use purchase() and PurchaseParams.Builder instead",
-        ReplaceWith("purchase()"),
-    )
-    fun purchaseProduct(


IMO I would leave these functions that don't have a UpgradeInfo. I think some people might still be using those, and we should try to minimize the changes if possible. Lmk if you think otherwise though!

Haha I'm fine with both, but I went off of @vegaro's comment:

only leave the purchase function that takes PurchaseParams.Builder

I'm happy to just do what the 2 of you agree on 😄

These were deprecated in the current major #825, that's where my suggestion for removal came from. If we don't remove them now, they will live for another major. Current major was released in September, I think 9 months is enough time to migrate to the purchase function?

Right, but I think it shouldn't be a big problem to keep those around right? And I think as long as it's not a problem, we should keep the deprecated functions. If at some point it becomes a problem, we can reconsider.

Sure, I see your point. For sure it's not a big problem to keep them around, my suggestion to remove them just comes from the fact that we normally remove deprecated functions in the next major, at least that's what we have been doing.

If we don't do some cleanup from time to time, it can become a huge mess to keep deprecated functions around forever, along with its kotlin conversions and their tests. They are also functions that won't be used in the docs snippets, possibly increasing our support burden, from people still using them.

IMO, I think if that's something we are going to start doing (keep deprecated functions forever as long as we can convert them to something non-deprecated), we should discuss it as a team and it should apply to all SDKs.

Agreed, I added it to our sync. Let's discuss it then!

I spoke to @tonidero yesterday and have concluded that it is probably better to keep them, so we focus on the developers and not on our own development experience. We can always remove them in the future if they become a pain to maintain. I think it's still worth to discuss in the meeting today so we all align for the future though.

Sorry for the back and forth, and for making you work on something that is getting scratched 😢

No worries, it's good exercise! 😄 I'll await today's meeting just in case, and will make the changes afterwards.

This is now done!

…urchase-methods # Conflicts: # api-tester/src/main/java/com/revenuecat/apitester/java/UpgradeInfoAPI.java # api-tester/src/main/java/com/revenuecat/apitester/kotlin/UpgradeInfoAPI.kt # examples/purchase-tester/src/main/java/com/revenuecat/purchasetester/DeprecatedOfferingFragment.kt # purchases/src/defaults/kotlin/com/revenuecat/purchases/Purchases.kt # purchases/src/main/kotlin/com/revenuecat/purchases/UpgradeInfo.kt # purchases/src/main/kotlin/com/revenuecat/purchases/common/Backend.kt # purchases/src/test/java/com/revenuecat/purchases/common/backend/BackendTest.kt

### Description PR to support pending prepaid purchase as a new feature added in BC7. This will be enabled by default but can be disabled through an option in `PurchasesConfiguration`: `pendingTransactionsForPrepaidPlansEnabled `.

This reverts commit 3003da6.

This reverts commit bb44815.

This reverts commit 46e6fb0.

This reverts commit 8f83ccc.

tonidero

This looks great!

tonidero · 2024-06-06T09:21:50Z

.../purchase-tester/src/main/java/com/revenuecat/purchasetester/DeprecatedPackageCardAdapter.kt

@@ -38,12 +39,13 @@ class DeprecatedPackageCardAdapter(
            binding.currentPackage = currentPackage
            binding.isSubscription = product.type == ProductType.SUBS
            binding.isActive = activeSubscriptions.contains(product.id)
+            // Upgrades are no longer possible with deprecated methods.


Honestly, I think it might make sense to just remove these deprecated classes now... I believe it was mostly used to test during the migration to the new ReplacementMode, but I think it wouldn't be very useful now... But this can also happen separately.

Alright! My vote would be to do it separately indeed, to avoid this PR from creeping up in scope.

Also quicker v8 beta 🚀 😄

JayShortway and others added 12 commits May 28, 2024 15:28

Bumps the purchases-android version to 8.0.0-SNAPSHOT.

691a910

Bumps the billing client to 7.0.0. (Fails to compile.)

d7007b4

Removes GoogleProrationMode, as ProrationMode is removed from BC7.

8ab5bfc

Bumps the minSdkVersion from 19 to 21.

57b48a9

Fixes some tests.

db4dde0

Renames local prorationMode field to replacementMode in UpgradeInfoAPI.

840446f

Co-authored-by: Cesar de la Vega <[email protected]>

Also renames reference to prorationMode to replacementMode in Upgrade…

5918c60

…InfoAPI. I should not blindly commit suggestions from GitHub :D

Removes UpgradeInfo and related purchase() methods.

9119bca

Removes all other deprecated purchase() methods.

bb44815

Fixes api-tester.

46e6fb0

Fixes purchase-tester.

8f83ccc

Fixes unitTests.

e7cb2a6

JayShortway added the pr:breaking Changes that are breaking label May 29, 2024

JayShortway commented May 29, 2024

View reviewed changes

...es/purchase-tester/src/main/java/com/revenuecat/purchasetester/DeprecatedOfferingFragment.kt Outdated Show resolved Hide resolved

JayShortway commented May 29, 2024

View reviewed changes

JayShortway requested a review from a team May 29, 2024 14:03

JayShortway mentioned this pull request May 29, 2024

SDK-3468 Minimal compatibility with BC7 #1707

Merged

tonidero reviewed May 30, 2024

View reviewed changes

Base automatically changed from sdk-3468-minimal-compatibility-with-bc7 to sdk-3465-support-bc7 May 30, 2024 09:06

JayShortway self-assigned this May 30, 2024

Removes an unused import from Purchases.

0eddd0f

JayShortway marked this pull request as draft June 5, 2024 08:55

tonidero and others added 5 commits June 5, 2024 17:47

Support pending prepaid purchases (#1717)

3003da6

### Description PR to support pending prepaid purchase as a new feature added in BC7. This will be enabled by default but can be disabled through an option in `PurchasesConfiguration`: `pendingTransactionsForPrepaidPlansEnabled `.

Revert "Support pending prepaid purchases (#1717)"

603cd78

This reverts commit 3003da6.

Revert "Removes all other deprecated purchase() methods."

a2aaf5f

This reverts commit bb44815.

Revert "Fixes api-tester."

b5c02d5

This reverts commit 46e6fb0.

Fixes api-tester again.

9b52608

JayShortway added 3 commits June 6, 2024 10:42

Revert "Fixes purchase-tester."

85547d7

This reverts commit 8f83ccc.

Fixes purchase-tester again.

0657bc1

Partially reverts PurchasesTest.

b26ff1e

JayShortway marked this pull request as ready for review June 6, 2024 09:01

JayShortway changed the base branch from sdk-3465-support-bc7 to 8.0.0-dev June 6, 2024 09:01

JayShortway changed the base branch from 8.0.0-dev to sdk-3465-support-bc7 June 6, 2024 09:01

tonidero approved these changes Jun 6, 2024

View reviewed changes

JayShortway merged commit 2a77293 into sdk-3465-support-bc7 Jun 6, 2024
9 checks passed

tonidero pushed a commit that referenced this pull request Jun 6, 2024

SDK-3469 Removes UpgradeInfo and purchase methods using it (#1711)

f57862e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK-3469 Remove deprecated purchase methods #1711

SDK-3469 Remove deprecated purchase methods #1711

JayShortway commented May 29, 2024

RevenueCat-Danger-Bot commented May 29, 2024 •

edited

Loading

JayShortway May 29, 2024

codecov bot commented May 29, 2024 •

edited

Loading

tonidero May 30, 2024

JayShortway May 30, 2024

vegaro Jun 3, 2024

tonidero Jun 3, 2024

vegaro Jun 3, 2024

tonidero Jun 3, 2024

vegaro Jun 5, 2024

JayShortway Jun 5, 2024

JayShortway Jun 6, 2024

tonidero left a comment

tonidero Jun 6, 2024

JayShortway Jun 6, 2024

JayShortway Jun 6, 2024

SDK-3469 Remove deprecated purchase methods #1711

SDK-3469 Remove deprecated purchase methods #1711

Conversation

JayShortway commented May 29, 2024

Breaking changes

RevenueCat-Danger-Bot commented May 29, 2024 • edited Loading

Choose a reason for hiding this comment

codecov bot commented May 29, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonidero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RevenueCat-Danger-Bot commented May 29, 2024 •

edited

Loading

codecov bot commented May 29, 2024 •

edited

Loading