Use trimmed API key #1768
Merged
Use trimmed API key #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
force-pushed
the
use-trimmed-api-key
branch
from
3b1609a
to
ea4998c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
=======================================
Coverage 83.26% 83.26%
=======================================
Files 223 223
Lines 7617 7618 +1
Branches 1071 1071
=======================================
+ Hits 6342 6343 +1
Misses 854 854
Partials 421 421 ☔ View full report in Codecov by Sentry. |
vegaro
reviewed
Jul 2, 2024
purchases/src/main/kotlin/com/revenuecat/purchases/PurchasesConfiguration.kt
Outdated
Show resolved
Hide resolved
vegaro
approved these changes
Jul 3, 2024
tonidero
added a commit
that referenced
this pull request
Jul 11, 2024
**This is an automatic release.** ### Bugfixes * Attempt to fix ANRs by moving some tasks during configure to background (#1772) via Cesar de la Vega (@vegaro) * Use trimmed API key (#1768) via Toni Rico (@tonidero) ### Other Changes * Remove leftovers `ExperimentalPreviewRevenueCatUIPurchasesAPI` (#1778) via Cesar de la Vega (@vegaro) * Update migration docs adding back support for `DEFERRED` upgrades (#1774) via Toni Rico (@tonidero) * Add 7.12.0 to CHANGELOG (#1769) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <[email protected]> Co-authored-by: Toni Rico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that trusted entitlements may fail if passing an API key with extra whitespaces. This is because it's part of the data we are verifying and the backend uses the trimmed version so there is a mismatch. This trims the API key we use in the SDK, so it matches what the backend uses in those cases. Any real API key shouldn't contain any whitespaces so I think it should be fine but lmk what you think