Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish paywall tester on each release #1803

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Aug 6, 2024

Description

This will make it so we publish paywall tester for internal testing on each SDK release

@tonidero tonidero added the ci label Aug 6, 2024
when:
and:
- equal: [ scheduled_pipeline, << pipeline.trigger_source >> ]
- equal: [ "nightly-deploy", << pipeline.schedule.name >> ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the CircleCI trigger, since it wasn't used for anything else

@tonidero tonidero marked this pull request as ready for review August 6, 2024 08:56
@tonidero tonidero requested a review from a team August 6, 2024 08:56
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.89%. Comparing base (3298244) to head (2b57e07).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1803   +/-   ##
=======================================
  Coverage   82.89%   82.89%           
=======================================
  Files         221      221           
  Lines        7660     7660           
  Branches     1074     1074           
=======================================
  Hits         6350     6350           
  Misses        891      891           
  Partials      419      419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tonidero tonidero merged commit f8ee985 into main Aug 6, 2024
9 checks passed
@tonidero tonidero deleted the publish-paywall-tester-each-release branch August 6, 2024 11:48
joshdholtz added a commit that referenced this pull request Aug 22, 2024
**This is an automatic release.**

### New Features
* [Paywalls] Add default locale (#1809) via Josh Holtz (@joshdholtz)
* [Paywalls] Support to round+truncate prices displayed on paywalls for
backend-specified countries (#1806) via James Borthwick (@jamesrb1)
### Other Changes
* Publish paywall tester on each release (#1803) via Toni Rico
(@tonidero)

---------

Co-authored-by: revenuecat-ops <[email protected]>
Co-authored-by: Josh Holtz <[email protected]>
@vegaro vegaro added pr:other and removed pr:ci labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants