ISSUE-1765: Make suspend coroutine wrappers cancellable #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for taking the effort to raise this PR! I replied in #1765. Let's discuss it there for now. |
IlyaPavlovskii
force-pushed
the
bugfix-issue-1765/make-coroutine-wrappers-cancellable
branch
from
219893a
to
3db0f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybridsMotivation
Stuck with the same problem mentioned in the issue 1765
Resolves #1765
Description
As it was mention in the description: when we cancel a coroutine using a job.cancel the suspendCoroutine doesn't cancel the revenueCat call.. but wrapping the normal non suspend function for get current customer in my own suspendCancellableCoroutine cancells the coroutine.
Checked on own integration - coroutines cancelled immediately after
job.cancel()call, instead of prev solution, when await function might execute some code postponed, event it was cancelled