Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recreating purchases same config #1866

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Oct 4, 2024

Description

This came from a conversation in Slack. I think we can limit the amount of multiple configuration issues if we don't reconfigure the SDK with the same parameters that were originally passed. I don't think there should be any use cases for that in any case? Keeping on hold to get feedback

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.35%. Comparing base (26074e4) to head (e8cd5f1).

Files with missing lines Patch % Lines
...com/revenuecat/purchases/PurchasesConfiguration.kt 71.42% 0 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
- Coverage   82.37%   82.35%   -0.03%     
==========================================
  Files         225      225              
  Lines        7900     7929      +29     
  Branches     1104     1119      +15     
==========================================
+ Hits         6508     6530      +22     
+ Misses        953      952       -1     
- Partials      439      447       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant