Remove embedding v1 support #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
force-pushed
the
remove-embedding-v1-support
branch
from
2d1df95
to
39cb1d3
Compare
tonidero
commented
Aug 13, 2024
| @@ -232,10 +201,6 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull Result result) { | |||
| case "syncPurchases": | |||
| syncPurchases(result); | |||
| break; | |||
| case "enableAdServicesAttributionTokenCollection": | |||
There was a problem hiding this comment.
Took the chance to cleanup a few warnings I was getting in Android studio.
JayShortway
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Looks good! Cross referenced with Flutter's own PR doing the same thing, and seems to be equivalent.
Comment on lines
-132
to
-134
| public Activity getActivity() { | ||
| return registrar != null ? registrar.activity() : activity; | ||
| } |
11 tasks
Merged
tonidero
added a commit
that referenced
this pull request
Aug 22, 2024
### Breaking Changes * Remove embedding v1 support (#1141) via Toni Rico (@tonidero) If you're using embedding v1, please check how to migrate in the [official flutter docs](https://docs.flutter.dev/release/breaking-changes/plugin-api-migration#upgrade-steps). ### Bugfixes * Refine StoreKitVersion logging in configure function (#1143) via Will Taylor (@fire-at-will) ### Other Changes * v7-MIGRATION.md typo fix (#1144) via Will Taylor (@fire-at-will)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove embedding v1 support as requested in #1135.