Paywalls: changed snapshots to scale 1 (#3016)

This reduces the total size of all paywall snapshots from 247MB to 34MB.
RevenueCat · Aug 28, 2023 · 79a391f · 79a391f
1 parent fcd674c
commit 79a391f
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 8 deletions.
diff --git a/Tests/StoreKitUnitTests/Support/DebugViewSwiftUITests.swift b/Tests/StoreKitUnitTests/Support/DebugViewSwiftUITests.swift
@@ -31,8 +31,7 @@ class DebugViewSwiftUITests: TestCase {
     }
 
     func testLoadingState() {
-        expect(self.view(with: .init(), width: 300, height: 400))
-            .to(haveValidSnapshot(as: .image))
+        self.snapshot(.init(), width: 300, height: 400)
     }
 
     func testDebugView() throws {
@@ -55,24 +54,24 @@ class DebugViewSwiftUITests: TestCase {
             response: .mockResponse
         ))
 
-        expect(self.view(with: model, width: 450, height: 900))
-            .to(haveValidSnapshot(as: .image))
+        self.snapshot(model, width: 450, height: 900)
     }
 
 }
 
 @available(iOS 16.0, *)
 private extension DebugViewSwiftUITests {
 
-    func view(
-        with model: DebugViewModel,
+    func snapshot(
+        _ model: DebugViewModel,
         width: CGFloat,
         height: CGFloat
-    ) -> some View {
+    ) {
         NavigationView {
             DebugSummaryView(model: model)
         }
             .frame(width: width, height: height)
+            .snapshot(size: CGSize(width: width, height: height))
     }
 
     static var mockCustomerInfo: CustomerInfo {

diff --git a/...UnitTests/Support/__Snapshots__/DebugViewSwiftUITests/iOS16-testDebugView.1.png b/...UnitTests/Support/__Snapshots__/DebugViewSwiftUITests/iOS16-testDebugView.1.png
diff --git a/...tTests/Support/__Snapshots__/DebugViewSwiftUITests/iOS16-testLoadingState.1.png b/...tTests/Support/__Snapshots__/DebugViewSwiftUITests/iOS16-testLoadingState.1.png
diff --git a/...UnitTests/Support/__Snapshots__/DebugViewSwiftUITests/iOS17-testDebugView.1.png b/...UnitTests/Support/__Snapshots__/DebugViewSwiftUITests/iOS17-testDebugView.1.png
diff --git a/...tTests/Support/__Snapshots__/DebugViewSwiftUITests/iOS17-testLoadingState.1.png b/...tTests/Support/__Snapshots__/DebugViewSwiftUITests/iOS17-testLoadingState.1.png
diff --git a/Tests/UnitTests/TestHelpers/SnapshotTesting+Extensions.swift b/Tests/UnitTests/TestHelpers/SnapshotTesting+Extensions.swift
@@ -67,7 +67,7 @@ extension SwiftUI.View {
             controller
         ).toEventually(
             haveValidSnapshot(
-                as: .image(perceptualPrecision: 0.98, size: size),
+                as: .image(perceptualPrecision: 0.98, size: size, traits: traits),
                 named: "1", // Force each retry to end in `.1.png`
                 file: file,
                 line: line
@@ -78,6 +78,10 @@ extension SwiftUI.View {
     }
 
 }
+
+// Generate snapshots with scale 1, which drastically reduces the file size.
+private let traits: UITraitCollection = .init(displayScale: 1)
+
 #endif
 
 private let timeout: DispatchTimeInterval = .seconds(5)